Fix export timestamp not working for prometheus on v2 #7289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Alvarez <[email protected]>
kir4h
force-pushed
the
enable-exporting-timestamp-prometheus-v2
branch
from
887e4b3 to
2a781c7
Compare
ssoroka
reviewed
Apr 6, 2020
ssoroka
approved these changes
Apr 6, 2020
danielnelson
pushed a commit
that referenced
this pull request
Apr 13, 2020
(cherry picked from commit df145c7)
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
veorlo
pushed a commit
to GlobalNOC/telegraf
that referenced
this pull request
May 4, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andres Alvarez [email protected]
Required for all PRs:
Summary
This PR fixes the behavior for
export_timestampconfiguration in prometheus output plugin when using metrics version 2, so that the timestamp is actually issued along with the metric.No update to the
README.mdis required I think, I take it this was the expected behaviour according to the documentation.